Based on number of times I've been there I'd say Edinburgh, although I could easily be persuaded to return to Vienna, Budapest, Reykjavik or London. Returning to Edinburgh in September.
+1 for Edinburgh. One of my favorite cities.
In the US, San Francisco is my favorite city to visit - perfect for a long weekend.